Please ignore my Ack. Sonic >-----Original Message----- >From: Zhang, Sonic >Sent: Thursday, May 09, 2013 4:31 PM >To: 'Libo Chen'; wsa@xxxxxxxxxxxxx >Cc: uclinux-dist-devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- >i2c@xxxxxxxxxxxxxxx; lizefan@xxxxxxxxxx >Subject: RE: [PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it init >successful > >Acked-by: Sonic Zhang <sonic.zhang@xxxxxxxxxx> > >>-----Original Message----- >>From: Libo Chen [mailto:libo.chen@xxxxxxxxxx] >>Sent: Thursday, May 09, 2013 4:27 PM >>To: Zhang, Sonic; wsa@xxxxxxxxxxxxx >>Cc: uclinux-dist-devel@xxxxxxxxxxxxxxxxxxxx; >>linux-kernel@xxxxxxxxxxxxxxx; linux- i2c@xxxxxxxxxxxxxxx; >>lizefan@xxxxxxxxxx; Libo Chen >>Subject: [PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before >>it init successful >> >>down out_error_no_irq. When platform_get_irq fail, no need to free >>peripheral >> >>Signed-off-by: Libo Chen <libo.chen@xxxxxxxxxx> >>--- >> drivers/i2c/busses/i2c-bfin-twi.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >>diff --git a/drivers/i2c/busses/i2c-bfin-twi.c >>b/drivers/i2c/busses/i2c-bfin-twi.c >>index 05080c4..6617645 100644 >>--- a/drivers/i2c/busses/i2c-bfin-twi.c >>+++ b/drivers/i2c/busses/i2c-bfin-twi.c >>@@ -709,9 +709,9 @@ static int i2c_bfin_twi_probe(struct >>platform_device *pdev) >> out_error_add_adapter: >> free_irq(iface->irq, iface); >> out_error_req_irq: >>-out_error_no_irq: >> peripheral_free_list((unsigned short *)pdev->dev.platform_data); >> out_error_pin_mux: >>+out_error_no_irq: >> iounmap(iface->regs_base); >> out_error_ioremap: >> out_error_get_res: >>-- >>1.7.1 >> >> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
