Re: [PATCH] ACPI / I2C: Use parent's ACPI_HANDLE() in acpi_i2c_register_devices()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, April 02, 2013 06:52:37 AM Wolfram Sang wrote:
> On Mon, Apr 01, 2013 at 02:25:03AM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > 
> > The ACPI handle of struct i2c_adapter's dev member should not be
> > set, because this causes that struct i2c_adapter to be associated
> > with the ACPI device node corresponding to its parent as the
> > second "physical_device", which is incorrect (this happens during
> > the registration of struct i2c_adapter).  Consequently,
> > acpi_i2c_register_devices() should use the ACPI handle of the
> > parent of the struct i2c_adapter it is called for rather than the
> > struct i2c_adapter's ACPI handle (which should be NULL).
> > 
> > Make that happen and modify the i2c-designware-platdrv driver,
> > which currently is the only driver for ACPI-enumerated I2C
> > controller chips, not to set the ACPI handle for the
> > struct i2c_adapter it creates.
> > 
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> 
> Shall this go via the I2C tree? If not, for the I2C part:

Well, I'm going to push it through the ACPI/PM tree, if that's not a problem
along with an analogous SPI patch.

> Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>

Thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux