Hi Lars, On Sat, 9 Mar 2013 19:16:43 +0100, Lars-Peter Clausen wrote: > Currently i2c_del_adapter() returns 0 on success and potentially an error code > on failure. Unfortunately this doesn't mix too well with the Linux device driver > model. (...) I see: struct device_driver { (...) int (*probe) (struct device *dev); int (*remove) (struct device *dev); So the driver core does allow remove functions to return an error. Are you going to fix all subsystems as you are doing for i2c now, and then change device_driver.remove to return void? If not, I don't see the point of changing it in i2c. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html