Hi Lars, On Sat, 9 Mar 2013 19:16:44 +0100, Lars-Peter Clausen wrote: > The detach_adapter callback has been deprecated for quite some time and has no > user left. Keeping it alive blocks other cleanups, so remove it. I'm all for it. Originally I intended to remove both attach_adapter and detach_adapter at the same time, unfortunately there are still users of attach_adapter around, despite it being deprecated for 2 or 3 years now. So the patch removing them is still sitting on my disk. Getting rid of at least detach_adapter now is a good idea. One minor comment: > @@ -1088,11 +1077,9 @@ int i2c_del_adapter(struct i2c_adapter *adap) > > /* Tell drivers about this removal */ > mutex_lock(&core_lock); > - res = bus_for_each_drv(&i2c_bus_type, NULL, adap, > + bus_for_each_drv(&i2c_bus_type, NULL, adap, > __process_removed_adapter); This would fit on a single line now. Reviewed-by: Jean Delvare <khali@xxxxxxxxxxxx> -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
