2013/3/27 Linus Walleij <linus.walleij@xxxxxxxxxx>: > On Mon, Mar 18, 2013 at 8:22 AM, Barry Song <Barry.Song@xxxxxxx> wrote: > >> From: Barry Song <Baohua.Song@xxxxxxx> >> >> hardcode set i2c pin group to i2c function before, here we >> move to use standard pinctrl API to get pins of the group. >> >> Signed-off-by: Barry Song <Baohua.Song@xxxxxxx> >> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > > NAK. > > This is done by the device core as of commit > ab78029ecc347debbd737f06688d788bd9d60c1d > "drivers/pinctrl: grab default handles from device core". > > You only need to fetch pinctrl handles in drivers if you're > using anything else than the default state. well. missed this recent commit. it should mean we hould drop all devm_pinctrl_get_select_default() if the driver only takes the default pinctrl? it looks like there are still a lot of drivers doing that. anyway, i will drop them in SiRFsoc drivers. and involve you in the coming patch. > > Yours, > Linus Walleij > -barry -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
