Hi Tony, > 1) I am working on pinmux at the moment - will hold off on this driver > until pinmux is completed. Cool, great work! > 2) > > + i2c_dev->clk = of_clk_get(np, 0); > > > > There is also devm_clk_get. > devm_clk_get requires a 'clock name'. > Since vt8500 is DT-only, and clock-names is an optional property in the > clocks binding I preferred not to *require* an optional property. OK then. Just wanted to mention it. Thanks, Wolfram -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html