On Mon, 28 Jan 2013 22:21:10 +0100, Amaury Decrême wrote:
> This patch corrects checkpatch errors.
>
> The changes has also been removed as it has less meaning with version
> control tools.
>
> Signed-off-by: Amaury Decrême <amaury.decreme@xxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-sis630.c | 210 ++++++++++++++++++++--------------------
> 1 file changed, 106 insertions(+), 104 deletions(-)
OK, this one needs a little more work to preserve code readability, see
below. As the 5 other patches are OK, please do not resend them, only
resend this one.
> diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c
> index 424545b..0376318 100644
> --- a/drivers/i2c/busses/i2c-sis630.c
> +++ b/drivers/i2c/busses/i2c-sis630.c
> (...)
> @@ -150,9 +131,10 @@ static inline void sis630_write(u8 reg, u8 data)
> outb(data, smbus_base + reg);
> }
>
> -static int sis630_transaction_start(struct i2c_adapter *adap, int size, u8 *oldclock)
> +static int sis630_transaction_start(struct i2c_adapter *adap, int size,
> + u8 *oldclock)
The most common practice is to align the beginning of the second line
with the opening parenthesis of the first. Like this:
static int sis630_transaction_start(struct i2c_adapter *adap, int size,
u8 *oldclock)
This is believed to be easier to read. Please do that everywhere it
applies and your patch will be good to go.
> (...)
> + } else if ((i - 1) % 8 == 7 || i == len) {
> + dev_dbg(&adap->dev,
> + "trans_wait len=%d i=%d\n", len, i);
> + if (i > 8) {
> + dev_dbg(&adap->dev,
> + "clear smbary_sts len=%d i=%d\n", len,
Indentation is wrong here.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
