On Fri, 4 Jan 2013 14:13:33 +0100, Amaury Decrême wrote: > This patch replaces hexadecimal values by constants for SMBus commands > and bit masks. > > Signed-off-by: Amaury Decrême <amaury.decreme@xxxxxxxxx> > --- > drivers/i2c/busses/i2c-sis630.c | 45 ++++++++++++++++++++++++++------------ > 1 files changed, 31 insertions(+), 14 deletions(-) > (...) Good idea, however you missed one occurrence of BYTE_DONE_STS in sis630_transaction_wait(). -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html