Re: [PATCH v5] i2c: nomadik: adopt pinctrl support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 24, 2013 at 09:47:22AM +0100, Linus Walleij wrote:
> From: Patrice Chotard <patrice.chotard@xxxxxxxxxxxxxx>
> 
> Amend the I2C nomadik pin controller to optionally take a pin control
> handle and set the state of the pins to:
> 
> - "default" on boot, resume and before performing an i2c transfer
> - "idle" after initial default, after resume default, and after each
>    i2c xfer
> - "sleep" on suspend()
> 
> This should make it possible to optimize energy usage for the pins
> both for the suspend/resume cycle, and for runtime cases inbetween
> I2C transfers.
> 
> Signed-off-by: Patrice Chotard <patrice.chotard@xxxxxxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

You forgot one else-branch :(

Do you run checkpatch before sending? '--strict' might be worth
considering then.

Fixed and applied to -next, thanks!

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux