On Wed, Dec 26, 2012 at 10:30:17AM +0800, Barry Song wrote: > From: Barry Song <Baohua.Song@xxxxxxx> > > the driver is also compatible with SiRFmarco except SiRFprimaII, > so simply add "sirf,marco-i2c" to OF match table. > > Signed-off-by: Barry Song <Baohua.Song@xxxxxxx> Why can't you use the existing compatible entry as a fallback like in: compatible = "sirf,marco-i2c", "sirf,prima2-i2c"; ? > --- > drivers/i2c/busses/i2c-sirf.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-sirf.c b/drivers/i2c/busses/i2c-sirf.c > index 181d7c2..ed38b16 100644 > --- a/drivers/i2c/busses/i2c-sirf.c > +++ b/drivers/i2c/busses/i2c-sirf.c > @@ -439,6 +439,7 @@ static const struct dev_pm_ops i2c_sirfsoc_pm_ops = { > > static const struct of_device_id sirfsoc_i2c_of_match[] __devinitconst = { > { .compatible = "sirf,prima2-i2c", }, > + { .compatible = "sirf,marco-i2c", }, > {}, > }; > MODULE_DEVICE_TABLE(of, sirfsoc_i2c_of_match); > -- -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html