Hi, > The init_completion() call does reinit not only the variable carrying > the flag that the completion finished, but also initialized the > waitqueue associated with the completion. On the contrary, the > INIT_COMPLETION() call only reinits the flag. > > In case there was anything still stuck in the waitqueue, subsequent call > to init_completion() would be able to create possible race condition. This > patch uses the proper function and moves init_completion() into .probe() > call of the driver, to be issued only once. > > Note that such scenario is impossible, since two threads can never enter > the mxs_i2c_xfer_msg(), since whole this section is protected by mutex in > I2C core. This by no means allows this issue to exit though. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > Cc: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > Cc: Shawn Guo <shawn.guo@xxxxxxxxxx> > Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> Why is this not applied / not in stable please? Also, what about the other MXS I2C patches? Thanks! Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
