Hi,
On Sun, Jan 20, 2013 at 02:32:58AM +0200, Aaro Koskinen wrote:
> The errata handling function acks wrong interrupt in case of "Arbitration
> lost". Fix it.
>
> Discovered during code review, the real impact of the bug is unknown.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
thanks for sending this
Reviewed-by: Felipe Balbi <balbi@xxxxxx>
> ---
> drivers/i2c/busses/i2c-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 20d41bf..832f16e 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -803,7 +803,7 @@ static int errata_omap3_i462(struct omap_i2c_dev *dev)
> if (stat & OMAP_I2C_STAT_AL) {
> dev_err(dev->dev, "Arbitration lost\n");
> dev->cmd_err |= OMAP_I2C_STAT_AL;
> - omap_i2c_ack_stat(dev, OMAP_I2C_STAT_NACK);
> + omap_i2c_ack_stat(dev, OMAP_I2C_STAT_AL);
> }
>
> return -EIO;
> --
> 1.7.10.4
>
--
balbi
Attachment:
signature.asc
Description: Digital signature
