On Thu, 10 Jan 2013 09:52:36 +0100, Laurent Navet wrote: > Hi Jean, > > > > > Unfortunately your patch also add one new checkpatch.pl warning: > > > > WARNING: line over 80 characters > > #245: FILE: drivers/i2c/busses/i2c-nforce2.c:272: > > + data->word = inb_p(NVIDIA_SMB_DATA) | (inb_p(NVIDIA_SMB_DATA + 1) << 8); > > > > Please fix. > > > > As mentioned previously, __devinit has been dropped meanwhile, so this > > change doesn't apply cleanly. Please rebase your patch on top of kernel > > 3.8-rc3 (or Wolfram's i2c tree) so that Wolfram can apply it. > > > > All the rest looks very good now, thanks for the good work. > > I've worked and tested against git.pengutronix.de wsa/linux.git > ( http://git.pengutronix.de/?p=wsa/linux.git;a=summary ) > Isnt' it the right one ? Only if you use branch i2c-embedded/for-next of that repository. Otherwise you're lacking the patch which removed the __dev* markers. Wolfram, it would be great if you could update your tree to avoid that kind of issue. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
