Hi Benjamin, On Wed, 12 Dec 2012 17:12:16 +0100, Benjamin Tissoires wrote: > We should not enter close function while someone else is in open. > This mutex prevents this race. > > There is also no need to override the ret value with -EIO in case of > a failure of i2c_hid_set_power. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxx> > --- Looks good to me except that you forgot to include <linux/mutex.h> and this could cause build failures on some architectures/configs. Once this is fixed, you can add: Reviewed-by: Jean Delvare <khali@xxxxxxxxxxxx> -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
