Jean Delvare writes: > > Hi Bill, > > On Tue, 27 Nov 2012 15:59:53 -0500, Bill Pemberton wrote: > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > > index 1e73638..6c5a732 100644 > > --- a/drivers/i2c/busses/i2c-i801.c > > +++ b/drivers/i2c/busses/i2c-i801.c > > @@ -841,13 +841,13 @@ struct dmi_onboard_device_info { > > const char *i2c_type; > > }; > > > > -static struct dmi_onboard_device_info __devinitdata dmi_devices[] = { > > +static struct dmi_onboard_device_info dmi_devices[] = { > > { "Syleus", DMI_DEV_TYPE_OTHER, 0x73, "fscsyl" }, > > { "Hermes", DMI_DEV_TYPE_OTHER, 0x73, "fscher" }, > > { "Hades", DMI_DEV_TYPE_OTHER, 0x73, "fschds" }, > > }; > > If I remember correctly, the only reason why this wasn't declared const > was because this was not compatible with __devinitdata. Now that > __devinitdata is gone, the leading "static" should become "static > const". Same goes for the 4 other occurrences in this patch, and I > suppose, many other cases in other subsystems. > Ok, do you want it resent with that change included? (along with the checkpatch changes, of course). -- Bill -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html