Re: [PATCH 16/16] i2c: SMBus: remove __dev* attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oh, BTW...

On Tue, 27 Nov 2012 15:59:53 -0500, Bill Pemberton wrote:
> diff --git a/drivers/i2c/busses/i2c-nforce2.c b/drivers/i2c/busses/i2c-nforce2.c
> index 392303b..fbea3cf 100644
> --- a/drivers/i2c/busses/i2c-nforce2.c
> +++ b/drivers/i2c/busses/i2c-nforce2.c
> @@ -117,7 +117,7 @@ struct nforce2_smbus {
>  #define MAX_TIMEOUT	100
>  
>  /* We disable the second SMBus channel on these boards */
> -static struct dmi_system_id __devinitdata nforce2_dmi_blacklist2[] = {
> +static struct dmi_system_id nforce2_dmi_blacklist2[] = {
>  	{
>  		.ident = "DFI Lanparty NF4 Expert",
>  		.matches = {
> @@ -330,7 +330,7 @@ static DEFINE_PCI_DEVICE_TABLE(nforce2_ids) = {
>  MODULE_DEVICE_TABLE (pci, nforce2_ids);
>  
>  
> -static int __devinit nforce2_probe_smb (struct pci_dev *dev, int bar,
> +static int nforce2_probe_smb (struct pci_dev *dev, int bar,
>  	int alt_reg, struct nforce2_smbus *smbus, const char *name)
>  {
>  	int error;

There is a checkpatch warning reported here:

WARNING: space prohibited between function name and open parenthesis '('
#390: FILE: drivers/i2c/busses/i2c-nforce2.c:333:
+static int nforce2_probe_smb (struct pci_dev *dev, int bar,

Please fix while you're here.

Thanks,
-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux