Hi, On Thu, Nov 08, 2012 at 06:25:24AM -0800, Leo Song wrote: > Would you please help to review and merge these 11 patches for > drivers/i2c/busses/i2c-pxa.c? There are already a few formal things: - For large series, please write a cover-letter describing the series in total (use --cover-letter). The omap guys do this very well, check the list archive. - why would upstream need Change-Id: in the patch description? - the cover letter should also state what testing you did. the pxa driver is used in lots of different SoCs and I'd like to know how much this was tested on other systems regarding regressions. - if you can't test it on other machines, ask for help. Putting alkml on CC is one way to do this - I'd ask you to add alkml anyway since your patches include hooks to the mach and there are people having more experience on this platform than me I didn't really have a look at the code yet, since I ask you to resend it fixing the above points first. But from a glimpse, you should try to avoid adding function pointers to platform_data at all costs. Maybe you can think of alternative solutions. Regards and thanks for the submission, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
