> -----Original Message----- > From: Wolfram Sang [mailto:w.sang@xxxxxxxxxxxxxx] > Sent: Tuesday, November 13, 2012 1:27 AM > To: Liu, Chuansheng > Cc: linus.walleij@xxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/7] I2c-nomadik: Fix the usage of > wait_for_completion_timeout > > On Wed, Nov 07, 2012 at 01:18:37AM +0800, Chuansheng Liu wrote: > > > > The return value of wait_for_completion_timeout() is always > > >= 0 with unsigned int type. > > > > So the condition "ret < 0" or "ret >= 0" is pointless. > > > > Signed-off-by: liu chuansheng <chuansheng.liu@xxxxxxxxx> > > You forgot to add the i2c-list, so I nearly overlooked this patch. > Luckily I haven't, so applied to for-next, thanks! Did you use a script > to find all occurences? Would be nice to know. Also, please take care of > the subject line. "I2c" is misspelled. Thanks your pointing out. I just manually reviewed the code when found this point. Would like to try some auto-script but failed:) -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
