> >>Yes SMBUS quick command is supported but is not managed in the > >>driver, we have to tell explicitly the IP that we want to send this > >>command. > > > >Ok, so unless you want to implement the support, please update this > >patch with a comment that SMBUS_QUICK is a TODO and remove the > >SMBUS_QUICK capability. > > > > Implementation should not be a huge task, only one bit to set in a > register but I have no device to test it. 'i2cdetect' from i2c-tools uses SMBUS_QUICK as one method to detect chips. Most slaves (both I2C and SMBus) react to that, so that would do in my book. > Did you test the driver with SMBus compatible devices? Can I keep > other SMBus capabilities from SMBUS_EMUL? The rest should be fine. -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
