On Oct 30, 2012, at 2:53 PM, Felipe Balbi wrote: > Hi, > > On Wed, Oct 31, 2012 at 05:55:30PM +0200, Pantelis Antoniou wrote: >> Enable pinctrl for i2c-omap. >> >> Signed-off-by: Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx> >> --- >> drivers/i2c/busses/i2c-omap.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c >> index db31eae..4c38aa0 100644 >> --- a/drivers/i2c/busses/i2c-omap.c >> +++ b/drivers/i2c/busses/i2c-omap.c >> @@ -44,6 +44,8 @@ >> #include <linux/i2c-omap.h> >> #include <linux/pm_runtime.h> >> #include <linux/pm_qos.h> >> +#include <linux/pinctrl/consumer.h> >> +#include <linux/err.h> >> >> /* I2C controller revisions */ >> #define OMAP_I2C_OMAP1_REV_2 0x20 >> @@ -1064,6 +1066,7 @@ omap_i2c_probe(struct platform_device *pdev) >> const struct of_device_id *match; >> int irq; >> int r; >> + struct pinctrl *pinctrl; >> >> /* NOTE: driver uses the static register mapping */ >> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> @@ -1202,6 +1205,13 @@ omap_i2c_probe(struct platform_device *pdev) >> >> of_i2c_register_devices(adap); >> >> + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); >> + if (IS_ERR(pinctrl)) >> + dev_warn(dev->dev, "unable to select pin group\n"); > > if we continue anyway, should this be dev_warn() ? Would you consider > dev_dbg() instead ? This has been the convention already in other drivers upstream. Discussed previously in http://www.spinics.net/lists/arm-kernel/msg192856.html and http://lkml.org/lkml/2012/9/11/369 That resulted in having dev_warn with a message of "pins are not configured from the driver" in both leds-gpio and spi-omap2-mcspi. It seems there should be a good reason to change reporting for the same case here. -Matt -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
