Hi, On Thu, Oct 25, 2012 at 06:13:16PM +0530, Santosh Shilimkar wrote: > On Thursday 25 October 2012 05:55 PM, Felipe Balbi wrote: > >In case we loop on IRQ handler until stat is > >finally zero, we would end up in a situation > >where all I2C transfers would misteriously > >timeout because we were not calling complete() > >in that situation. > > > >Fix the issue by moving omap_i2c_complete_cmd() > >call inside the 'out' label. > > > >Signed-off-by: Felipe Balbi <balbi@xxxxxx> > >--- > Looks fine. Have you hit this issue in any corner case ? in fact, yes. With a difficult to reproduce situation with drv2665 (one of TI's piezo drivers) I saw that I was missing the ack and all transfers were timing out ;-) -- balbi
Attachment:
signature.asc
Description: Digital signature
