Hi, ti, 2012-10-16 kello 17:59 +0300, Kalle Jokiniemi kirjoitti: > The irqs are enabled one-by-one in pm core resume_noirq phase. > This leads to situation where the twl4030 primary interrupt > handler (PIH) is enabled before the chained secondary handlers > (SIH). As the PIH cannot clear the pending interrupt, and > SIHs have not been enabled yet, a flood of interrupts hangs > the device. > > Fixed the issue by setting the SIH irqs with IRQF_EARLY_RESUME > flags, so they get enabled before the PIH. Did it this way now, since the tl4030_irq is not really a driver that could do normal suspend / resume calls... and this is what the flag is for. Added Samuel to recipients, as get_maintainer reported him as maintainer. - Kalle > > Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@xxxxxxxxxxxxxxx> > --- > drivers/mfd/twl4030-irq.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c > index ad733d7..cdd1173 100644 > --- a/drivers/mfd/twl4030-irq.c > +++ b/drivers/mfd/twl4030-irq.c > @@ -672,7 +672,8 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base) > irq = sih_mod + twl4030_irq_base; > irq_set_handler_data(irq, agent); > agent->irq_name = kasprintf(GFP_KERNEL, "twl4030_%s", sih->name); > - status = request_threaded_irq(irq, NULL, handle_twl4030_sih, 0, > + status = request_threaded_irq(irq, NULL, handle_twl4030_sih, > + IRQF_EARLY_RESUME, > agent->irq_name ?: sih->name, NULL); > > dev_info(dev, "%s (irq %d) chaining IRQs %d..%d\n", sih->name, -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
