Hi Jean, >> When the discussion is settled I'd probably go directly to I2C_MSG_ macros in order to avoid a double conversion. > I thought about it, but actually I'd rather pick Shubhrajyoti's patches > first. We don't know where Julia's patch will be going at this point, > and other patches depend on the patches Shubhrajyoti sent, which I do > not want to delay. Julia's changes, if applied, will touch over 200 > drivers anyway, so 4 more or less don't make any difference. I also > suspect that Julia's scripts won't catch the non-C99 initializations, > so she probably won't see them Shubhrajyoti's patches are applied - > that's one more reason to apply them immediately. Thanks for your input, I just read also your reply to Julia's patchset - so I'm fine with the patch. > so she probably won't see them Shubhrajyoti's patches are applied... Hehe, I tend to look at the i2c subsystem from time to time to catch-up with the new features (e.g. __i2c_transfer for this driver) and apply them to stuff I'm aware of ;) - but of course you're right. Reviewed-by: Peter Huewe <peter.huewe@xxxxxxxxxxxx> And as the driver's author: Acked-by: Peter Huewe <peter.huewe@xxxxxxxxxxxx> Thanks, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
