Re: [PATCH] i2c/scx200_*: replace printks with pr_<level>s, rev2 checkpatch clean

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jim,

On Sat, 15 Sep 2012 22:03:21 -0600, Jim Cromie wrote:
> Replace printks with pr_<level>s, add pr_fmt()s to replace NAMEs
> 
> Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>
> ---
>  drivers/i2c/busses/scx200_acb.c | 22 +++++++++++-----------
>  drivers/i2c/busses/scx200_i2c.c | 13 +++++++------
>  2 files changed, 18 insertions(+), 17 deletions(-)

This looks good, thanks for the cleanup. But you can go one step
further and remove the NAME defines, as they are no longer used
anywhere in the drivers.

I did that for you, no need to resend. Patch applied.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux