On Fri, 2012-09-14 at 21:21 -0600, Jim Cromie wrote: > Replace printks with pr_<level>s, add pr_fmt()s to replace NAMEs Hi Jim. When you do these, please maximally fill to 80 columns the printk arguments and coalesce formats without regard to 80 columns. > diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c > @@ -406,7 +408,7 @@ static __devinit int scx200_acb_probe(struct scx200_acb_iface *iface) > > val = inb(ACBCTL1); > if (val) { > - pr_debug(NAME ": disabled, but ACBCTL1=0x%02x\n", > + pr_debug("disabled, but ACBCTL1=0x%02x\n", > val); pr_debug("disabled, but ACBCTL1=0x%02x\n", val); > @@ -417,7 +419,7 @@ static __devinit int scx200_acb_probe(struct scx200_acb_iface *iface) > > val = inb(ACBCTL1); > if ((val & ACBCTL1_NMINTE) != ACBCTL1_NMINTE) { > - pr_debug(NAME ": enabled, but NMINTE won't be set, " > + pr_debug("enabled, but NMINTE won't be set, " > "ACBCTL1=0x%02x\n", val); pr_debug("enabled, but NMINTE won't be set, ACBCTL1=0x%02x\n", val); etc... -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html