On Wed, Sep 12, 2012 at 08:39:50PM -0700, Guenter Roeck wrote: > From: Thomas Kavanagh <tkavanagh@xxxxxxxxxxx> > > The parameter passed to pca9665_reset is adap->data, not adap. Unless > adap->data happens to point back to adap, this can result in a kernel panic. Can you please update this paragraph with a short explanation of what we discussed (i.e. why exactly the kernel can crash)? > > Fix re-factoring pca_reset() from a macro to a function to handle chip > specific code, and only call adap->reset_chip() if the chip is not PCA9665. > > Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > Signed-off-by: Thomas Kavanagh <tkavanagh@xxxxxxxxxxx> > Signed-off-by: Guenter Roeck <groeck@xxxxxxxxxxx> Patch itself is good. -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
