Re: [PATCH v2] i2c-core: Fix for lockdep validator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 7 Sep 2012 22:58:44 +0200, Jean Delvare wrote:
> If kernel is compiled with CONFIG_PROVE_LOCKING the
> validator raises an error when a multiplexer is removed
> via sysfs and sub-clients are connected to it. This is a
> false positive.
> Documentation/lockdep-design.txt recommends to handle this
> via calls to mutex_lock_nested().
> 
> Based on an earlier fix from Michael Lawnick.
> 
> Note that the extra code resolves to nothing unless
> CONFIG_DEBUG_LOCK_ALLOC=y.

... which in turn causes a compiler warning if CONFIG_DEBUG_LOCK_ALLOC
isn't set.

drivers/i2c/i2c-core.c:639:21: warning: ‘i2c_adapter_depth’ defined but not used [-Wunused-function]

Not sure how I missed that yesterday. I'll make the function inline,
that should fix it, and that's what gcc ends up doing anyway.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux