Re: I2C_FUNC_SMBUS_QUICK on i2c-mxs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 30, 2012 at 03:34:27PM +0200, Marek Vasut wrote:
> Dear Wolfram Sang,
> 
> > > So I'd say that'd rather be flub of the original author of the driver,
> > > being lazy and not testing the corner cases properly? I can't run git
> > > blame to detect who did it now,
> > :
> > :)
> 
> %^)
> 
> Hit dogs will holler. Sorry, I'm not on my work machine now. So Wolfram, can you 
> please comment?

I never needed SMBUS_QUICK and left that check from the original
sources. Datasheet doesn't say anything if 0 means nothing or 64K
(because of underrun). Could be worth trying out and instrumenting the
bus with a scope.

PS: Your DMA patches are scheduled for next week (yes, really!)

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux