Re: [PATCH] i2c: i2c-sh_mobile device tree support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 30, 2012 at 5:47 PM, Paul Mundt <lethal@xxxxxxxxxxxx> wrote:
> On Fri, Mar 30, 2012 at 05:44:02PM +0900, Magnus Damm wrote:
>> +static const struct of_device_id sh_mobile_i2c_dt_ids[] __devinitconst = {
>> +     { .compatible = "renesas,rmobile-iic", },
>> +     {},
>> +};
>> +MODULE_DEVICE_TABLE(of, sh_mobile_i2c_dt_ids);
>> +
> Given that this block predates R-Mobile, using the rmobile naming here is
> pretty dubious. I suppose you can have it as an alias, though.

Sure, but creating new code based an old naming conventions seem rather odd too.

Of course, if you think it is cramping your SH device tree style then
we can easily add a "renesas-shmobile-iic" entry as well.

Cheers,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux