On Sun, Mar 25, 2012 at 2:41 PM, Jean Delvare <khali@xxxxxxxxxxxx> wrote: > On Sun, 25 Mar 2012 13:29:51 -0400, jonsmirl@xxxxxxxxx wrote: >> All of the OF aware i2c bus drivers need to do: >> of_i2c_register_devices(&alg_data->adapter); >> >> Can this be moved to the common core code? > > I seem to recall that someone once proposed to move the call to > i2c-core, but the dependencies and #ifdef mess that resulted made me > reject it. That doesn't mean it can't be done, but just moving the call > is not the way. You could make the #ifdef go away by putting an #ifdef into <linux/of_i2c.h> to stub out the call when CONFIG_OF is not defined. I don't think the dependencies are as much of a problem anymore. I'm bringing up a new ARM platform and didn't have any problem adding it. I just noticed that is was duplicated in a dozen bus drivers. > > -- > Jean Delvare -- Jon Smirl jonsmirl@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
