eg20t i2c driver: missing some changes?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

I am using i2c-eg20t on linux 3.1.6 and comparing with the current source on 3.3-rc4

I think there is a (few) missing cleanup between the version pasted on:
http://www.spinics.net/lists/linux-i2c/msg06664.html

to the one in version 3.3-rc4

one of it is this change in pch_i2c_getack

@@ -348,7 +347,7 @@
 	reg_val = ioread32(p + PCH_I2CSR) & PCH_GETACK;

 	if (reg_val != 0) {
-		pch_err(adap, "return%d\n", -EPROTO);
+		pch_dbg(adap, "return%d\n", -EPROTO);
 		return -EPROTO;
 	}

Without this change, using i2cdetect will generate a lot of false positive errors on devices that are not present.
I'm not sure if there is a patch that is missed or still being reviewed that contained this change

There are also some other differences between the mailing list version and linux-3.3rc4 in addition to this one,
but I don't have enough background to comment on them.

--
Richard Retanubun
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux