On Tue, Feb 14, 2012 at 4:35 AM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > Use the PM_SLEEP ifdef for system suspend and resume. This is partly > in preparation for adding runtime operations and partly because a user > may in theory choose to enable runtime suspend but not system suspend. > Yes also rand defconfig may see some warns. Looks good to me Reviewed-by: Shubhrajyoti D <shubhrajyoti@xxxxxx> > Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > --- > drivers/i2c/busses/i2c-s3c2410.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c > index 1cb06c58..5d8e802 100644 > --- a/drivers/i2c/busses/i2c-s3c2410.c > +++ b/drivers/i2c/busses/i2c-s3c2410.c > @@ -1073,7 +1073,7 @@ static int s3c24xx_i2c_remove(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM > +#ifdef CONFIG_PM_SLEEP > static int s3c24xx_i2c_suspend_noirq(struct device *dev) > { > struct platform_device *pdev = to_platform_device(dev); > @@ -1096,10 +1096,14 @@ static int s3c24xx_i2c_resume(struct device *dev) > > return 0; > } > +#endif > > +#ifdef CONFIG_PM > static const struct dev_pm_ops s3c24xx_i2c_dev_pm_ops = { > +#ifdef CONFIG_PM_SLEEP > .suspend_noirq = s3c24xx_i2c_suspend_noirq, > .resume = s3c24xx_i2c_resume, > +#endif > }; > > #define S3C24XX_DEV_PM_OPS (&s3c24xx_i2c_dev_pm_ops) > -- > 1.7.9.rc1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html