Hi Shubhrajyoti, On 02/14/2012 02:03 PM, Shubhrajyoti Datta wrote: > Hi Mark, > > The changes look good to me. > Reviewed-by: Datta Shubhrajyoti <shubhrajyoti@xxxxxx> > For your changes. > > Some other doubts though not related to your patch. > Just curious. > ... >> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c >> index 4c17180..e6f982b 100644 >> --- a/drivers/i2c/busses/i2c-s3c2410.c >> +++ b/drivers/i2c/busses/i2c-s3c2410.c ... >> @@ -1061,7 +1060,6 @@ static int s3c24xx_i2c_remove(struct platform_device *pdev) >> release_resource(i2c->ioarea); >> s3c24xx_i2c_dt_gpio_free(i2c); >> kfree(i2c->ioarea); > Do we need both release_resource and kfree No, instead of release_resource() and kfree() you normally use release_mem_region() to free resources acquired with request_mem_region(). See this patch for instance: http://www.spinics.net/lists/linux-samsung-soc/msg08325.html -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
