On Tue, 14 Feb 2012 10:10:13 +0100, Jean Delvare wrote: > On Mon, 13 Feb 2012 23:26:43 +0100, Wolfram Sang wrote: > > On Mon, Feb 13, 2012 at 05:05:03PM +0800, Axel Lin wrote: > > > This patch converts the drivers in drivers/i2c/* to use the > > > module_i2c_driver() macro which makes the code smaller and a bit simpler. > > > > > > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx> > > > Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > > > Cc: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx> > > > Cc: Jean Delvare <khali@xxxxxxxxxxxx> > > > Cc: Michael Lawnick <ml.lawnick@xxxxxx> > > > Cc: Ben Dooks <ben-linux@xxxxxxxxx> > > > > Acked-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > > Patch applied, thanks. Hmm, on second thought... I'm not going to apply the i2c-smbus patch. This is a special module, it isn't a device driver per se. It happens that right now the only SMBus extension supported by the i2c-smbus module is SMBus Alert and it happens that this is implemented as an i2c_driver, but as we add support for more SMBus extensions to that driver, the init and exit functions will likely become more complex, and then we'd have to move away from module_i2c_driver(). So I'd rather not use it to start with. I am taking the drivers/i2c/muxes/pca954*.c parts though. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
