On Mon, Feb 06, 2012 at 07:38:29PM +0100, Karol Lewandowski wrote: > On 05.02.2012 11:38, Jean-Christophe PLAGNIOL-VILLARD wrote: > > Hi! > > >+Device-Tree bindings for i2c gpio driver > >+ > >+Required properties: > >+ - compatible = "gpio-i2c"; > > Driver name is "i2c-gpio" in file i2c-gpio.c. Previous version of > patch adding DT-support (prepared by Thomas Chou[1]) used i2c-gpio - > could we stick to that name? > > [1] https://lkml.org/lkml/2011/2/23/584 > > >+ - gpios: sda and scl gpio > >+ > >+ > >+Optional properties: > >+ - gpio-i2c,sda_is_open_drain: sda as open drain > >+ - gpio-i2c,scl_is_open_drain: scl as open drain > >+ - gpio-i2c,scl_is_output_only: scl as output only > > Most of DT-properties I've seen used hyphen, not underscore. Could > we stick to that convention? > > (Nitpick: I think that "is" in property names is redundant too.) > > >+ - udelay: half clock cycle time in us (may depend on each platform) > > Could we use "clock-frequency" as Grant have suggested during review > of previous patch to i2c-gpio? I'm with Grant on that, it would be nice to have a reasonably sane set of default i2c dt bindings that everyone uses. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
