Re: [PATCH 1/4] i2c/gpio-i2c add: add DT support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16:09 Mon 06 Feb     , Mark Brown wrote:
> On Sun, Feb 05, 2012 at 11:38:53AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> 
> > +	- udelay: half clock cycle time in us (may depend on each platform)
> 
> > +	udelay = <2>;		/* ~100 kHz */
> 
> Why not specify this in kHz and do the conversion in the driver?  It
> seems a more intuitive thing to be specifying.  I appreciate that the
> platform data used udelay but it seems an entirely unintuitive thing
> from a user point of view even if it's what the implementation wants.
because it's not accurate and on some platform you need to adapt it so we keep
the udelay

as example due to latency when changing state of the gpio as we may access it
via i2c or internal bus latency

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux