Re: [PATCH] (RESEND #2) i2c: prevent spurious interrupt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alan,

On Thu, 26 Jan 2012 16:13:34 +0000, Alan Cox wrote:
> From: Kristen Carlson Accardi <kristen@xxxxxxxxxxxxxxx>
> 
> Don't call i2c_enable on resume because it causes a spurious
> interrupt.
> 
> Signed-off-by:  Kristen Carlson Accardi <kristen@xxxxxxxxxxxxxxx>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
> ---
> 
>  drivers/i2c/busses/i2c-designware-pcidrv.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

Please come up with a decent subject line for this patch. Currently it
sounds very generic so Ben will never look at it, assuming I will take
care of it. But it is actually driver-specific, and that's a driver Ben
is responsible for, so I won't pick it.

> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index 37f4211..00e8f21 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -182,7 +182,6 @@ static int i2c_dw_pci_resume(struct device *dev)
>  	pci_restore_state(pdev);
>  
>  	i2c_dw_init(i2c);
> -	i2c_dw_enable(i2c);
>  	return 0;
>  }
>  


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux