On Sat, Jan 21, 2012 at 10:25:20PM +0100, Sylwester Nawrocki wrote: > On 01/21/2012 07:46 PM, Mark Brown wrote: > > Add stub runtime_pm calls which go through the flow of enabling and > > disabling but don't actually do anything with the device itself as > > there's nothing useful we can do. This provides the core PM framework > > with information about when the device is idle, enabling chip wide > > power savings. > Sorry, unless I'm missing something, currently there is no clock or > power domain drivers for the I2C controllers in any SoC versions this > driver is used with. So it seems like this patch introduces just > an overhead of pm_runtime calls, in addition to clk_enable/disable. > I can't see what the PM core would use the information about device's > power state for. Is there really anything else, regarding I2C controllers > power management, than can be done except individual devices' clock > gating ? Lots of the SoCs have system wide WFI modes (like the STOP and DEEP-STOP modes of the S3C64xx) which will gate the power to the I2C controller and also do system wide things like put the RAM into self refresh mode. These modes all require that the device be idle at the SoC level so we need to know that all the IPs within the SoC are quiesced which is what I'm shooting for with all these patches. The wins from these modes are definitely worth the effort. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
