On Sat, Jan 21, 2012 at 05:10:22PM +0100, Sylwester Nawrocki wrote: > > - i2c = kzalloc(sizeof(struct s3c24xx_i2c), GFP_KERNEL); > > + i2c = devm_kzalloc(&pdev->dev, sizeof(struct s3c24xx_i2c), GFP_KERNEL); > Just in case you are resending the patch for any other reason, it might be worth > to change to sizeof(*i2c) for consistency. Consistency with...? TBH I'd rather not change the coding style as well as presumably Ben likes that the way it is. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html