Hi Benoit, On Tue, Jan 03, 2012 at 03:09:49PM +0100, Cousson, Benoit wrote: > On 1/2/2012 10:04 AM, Grant Likely wrote: > > On Thu, Dec 22, 2011 at 03:56:37PM +0100, Benoit Cousson wrote: > >> Add initial device-tree support for twl familly chips. > >> The current version is missing the regulator entries due > >> to the lack of DT regulator bindings for the moment. > >> Only the simple sub-modules that do not depend on > >> platform_data information can be initialized properly. > >> > >> Add irqdomain support. > >> > >> Add documentation for the Texas Instruments TWL Integrated Chip. > >> > >> Signed-off-by: Benoit Cousson<b-cousson@xxxxxx> > >> Cc: Balaji T K<balajitk@xxxxxx> > >> Cc: Graeme Gregory<gg@xxxxxxxxxxxxxxx> > >> Cc: Samuel Ortiz<sameo@xxxxxxxxxxxxxxx> > >> --- > >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > >> index f1391c2..f0de088 100644 > >> --- a/drivers/mfd/Kconfig > >> +++ b/drivers/mfd/Kconfig > >> @@ -200,6 +200,7 @@ config MENELAUS > >> config TWL4030_CORE > >> bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support" > >> depends on I2C=y&& GENERIC_HARDIRQS > >> + select IRQ_DOMAIN > > > > As discussed on linux-next, this breaks powerpc. Drivers cannot select > > IRQ_DOMAIN, it can only be selected by architectures. Drivers must depend > > on it instead. > > OK, good to know. The previous version was already breaking non-ARM platform because the IRQ_DOMAIN was not defined, hence this update. > I was able to check that this patch was fixing at least x86... but did not have any way to check the PPC build. > > To be honest, I did not fully understand that this flag was there because some arch does not support IRQ domain yet and thus it should be selected at arch level. > > Samuel, > Here is the updated version, and hopefully the last one, including Grant's fix. > Thanks, I applied it now. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
