From: Jean Delvare <khali@xxxxxxxxxxxx> Date: Thu, 5 Jan 2012 21:06:00 +0100 > On Thu, 05 Jan 2012 14:55:10 -0500 (EST), David Miller wrote: >> Using the raw PCI config register value in the non-IO case is always >> wrong and non-portable. You need to ioremap the thing using the PCI >> resource if it's not IO and therefore MEM. >> >> More easier, if non-IO is really not expected, would be to fail the >> probe if we don't find IORESOURCE_IO set. > > It's indeed not expected, and failing is what Corentin's original patch > was doing. I had him change (actually did the change myself with his > approval) to limit the risk of regression. I don't expect MEM but maybe > no resource type at all (i.e. BAR 0 unused.) > > The rationale is that old PC boards use the same PCI chipset and we > were not able to find any tester. I have no idea what the PCI resources > look like on these machines, but I know the driver used to work OK, so > the strategy is to make the new code behave the same as the original > code if things don't look as expected. > > We can revisit if/when we find a tester with ALI1535 on x86. Ok. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
