RE: [PATCH V2 1/4] i2c: tegra: Add __devinit/exit to probe/remove

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Shubhrajyoti Datta wrote at Sunday, December 18, 2011 11:54 PM:
> On Sun, Dec 18, 2011 at 11:59 AM, Stephen Warren <swarren@xxxxxxxxxx> wrote:
> > This fixes some section mismatch build warnings.
>
> What was the error was a devinit function called from these?

As I Understand It, probe/remove are devinit/exit functions, and hence
should be marked as such.

The errors were from building with CONFIG_DEBUG_SECTION_MISMATCH=y.

I guess the section mismatch errors won't actually show up in the code
that's in the kernel right now; they only showed up because I had a local
patch that modified probe() to reference tegra_i2c_of_match[] which is
__devinitconst. I since reworked that patch so that it doesn't introduce
that reference, for other reasons. Still, I think this is a good cleanup
change even if nothing is actually causing these mismatch errors to fire
right now.

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux