I have tested this patch. It works on p1022ds platform. Thanks. Regards, Yuantian > -----Original Message----- > From: Guenter Roeck [mailto:guenter.roeck@xxxxxxxxxxxx] > Sent: 2011年11月18日 2:19 > To: sun york-R58495 > Cc: Jean Delvare; Tabi Timur-B04825; linux-i2c@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Tang Yuantian-B29983 > Subject: Re: [PATCH] i2c/busses: (mpc) Add support for > SMBUS_READ_BLOCK_DATA > > If you look closely, you may realize that the mpc_read also doesn't > validate of any of the other parameters. Are you going to request that > such validations be added as well ? How about the other functions in this > driver ? Should each function also validate each of its parameters ? If > not, where do you draw the line ? > > Besides, the caller is the SMBus block read function, which does know > that SMBus block reads are limited to 32 bytes (plus length). > > Guenter > > ��.n��������+%������w��{.n�����{��-��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
