Hi Pratyush Anand, On Wed, Nov 16, 2011 at 10:28:07AM +0530, Pratyush Anand wrote: > There are few drivers(for example stmpe-gpio) which are available on i2c > bus but has been initialized as subsys initcall. Therefore i2c driver > must also be initialized as subsys initcall. > > Signed-off-by: Pratyush Anand <pratyush.anand@xxxxxx> > --- NAK. Dependency problem like this one should be solved using the probe deferral mechanism, when it's merged (http://thread.gmane.org/gmane.linux.ports.arm.omap/65436). Sprinkling those really_really_early_initcall() all over the place is unreasonable IMO. baruch > drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +- > drivers/i2c/busses/i2c-designware-platdrv.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c > index 9e89e73..7854565 100644 > --- a/drivers/i2c/busses/i2c-designware-pcidrv.c > +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c > @@ -379,7 +379,7 @@ static int __init dw_i2c_init_driver(void) > { > return pci_register_driver(&dw_i2c_driver); > } > -module_init(dw_i2c_init_driver); > +subsys_initcall(dw_i2c_init_driver); > > static void __exit dw_i2c_exit_driver(void) > { > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c > index 2d3657a..4fbdcd5 100644 > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > @@ -202,7 +202,7 @@ static int __init dw_i2c_init_driver(void) > { > return platform_driver_probe(&dw_i2c_driver, dw_i2c_probe); > } > -module_init(dw_i2c_init_driver); > +subsys_initcall(dw_i2c_init_driver); > > static void __exit dw_i2c_exit_driver(void) > { -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
