Hi,
> > +#include <mach/at91_twi.h>
> > +#include <mach/board.h>
> > +#include <mach/cpu.h>
>
> avoid including <mach/*> on drivers.
Should I move at91_twi.h to include/linux (omap does it like this,
other use the mach-include)?
> > + if (irqstatus & AT91_TWI_TXCOMP) {
> > + at91_disable_twi_interrupts(dev);
> > + dev->transfer_status = status;
> > + complete(&dev->cmd_complete);
> > + }
> > + else if (irqstatus & AT91_TWI_RXRDY) {
> > + at91_twi_read_next_byte(dev);
> > + }
> > + else if (irqstatus & AT91_TWI_TXRDY) {
> > + at91_twi_write_next_byte(dev);
> > + }
> > + else {
> > + return IRQ_NONE;
>
> coding style is wrong. Also, are those IRQ events really mutually exclusive ??
These are indeed mutually exclusive (semantically).
Niko
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
