On 9/12/2011 9:16 PM, Thomas Abraham wrote: > @@ -809,6 +810,15 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) > return -ENOMEM; > } > > + i2c->pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); > + if (!i2c->pdata) { > + ret = -ENOMEM; > + goto err_noclk; > + } > + > + if (pdata) > + memcpy(i2c->pdata, pdata, sizeof(*pdata)); > + Is there a devm_kmemdup()? If not, maybe it would be a good idea to add it. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html