Shubhrajyoti D <shubhrajyoti@xxxxxx> writes:
> - The reset in the driver at init is not needed anymore as the
> hwmod framework takes care of reseting it.
> - Reset is removed from omap_i2c_init, which was called
> not only during probe, but also after time out and error handling.
> device_reset were added in those places to effect the reset.
> - Earlier the hwmod SYSC settings were over-written in the driver.
> Removing the same and letting the hwmod take care of the settings.
> - Clean up the SYSS_RESETDONE_MASK macro as it is no longer needed.
> - Clean up the SYSCONFIG SYSC bit defination macros.
> - Fix the typos in wakeup.
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@xxxxxx>
I asked this in an earlier version, but here it is again.
Are you sure a full IP reset is needed on the timeout and error
conditions and not just the module-level one done by:
omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, 0);
[ and later... ]
/* Take the I2C module out of reset: */
omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, OMAP_I2C_CON_EN);
I kind of suspect that the IP rese was done because the omap_i2c_init()
function was callled under the timeout/error conditions, but that a full
IP SW reset is a bit heavy handed.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
