On Tue, Aug 09, 2011 at 09:21:31AM -0700, Stephen Warren wrote: > Stephen Warren wrote at Monday, August 08, 2011 1:26 PM: > > Rob Herring wrote at Sunday, August 07, 2011 8:38 AM: > > > On 08/05/2011 05:50 PM, Stephen Warren wrote: > > > > The patch adds empty function of_get_property for non-dt build, so that > > > > drivers migrating to dt can save some '#ifdef CONFIG_OF'. > > > > > > > > This also fixes the current Tegra compile problem in linux-next. > > > > > > You could just use of_property_read_u32 in the driver. It already has > > > empty version and will simplify the driver code some. > > > > Yes, that would also work. > > > > Grant, Ben, do you have a preference for which option to choose? > > Well, all three possible fixes have been posted now: > > Add ifdef to i2c driver: > http://www.spinics.net/lists/linux-tegra/msg01720.html > > Implement empty of_get_property: > http://www.spinics.net/lists/linux-tegra/msg01881.html > > Switch i2c driver to use of_property_read_u32: > http://permalink.gmane.org/gmane.linux.ports.arm.kernel/127807 > > Ben, please could you please pick one of the changes and apply it, so > that linux-next compiles for Tegra? Thanks! I'll look into this at the weekend, of_property_read_u32 is probably a better function to call. > -- > nvpublic > -- Ben Dooks, ben@xxxxxxxxx, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
