On Tue, Jun 21, 2011 at 10:54:56AM +0200, Jean Delvare wrote:
> On Mon, 20 Jun 2011 23:01:14 +0200, Wolfram Sang wrote:
> > A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> > on exit or error. This is obsolete meanwhile, the core will do it.
> >
> > Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> > Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> > Cc: Anton Vorontsov <cbouatmailru@xxxxxxxxx>
> > Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>
> Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>
Anton, can you pick it for 3.1?
>
> > ---
> >
> > This is more a cleanup than a bugfix. Still, would be happy to have this
> > obsolete programming style largely removed in 3.0 if possible.
> >
> > drivers/power/max17042_battery.c | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
> > index c5c8805..09f7496 100644
> > --- a/drivers/power/max17042_battery.c
> > +++ b/drivers/power/max17042_battery.c
> > @@ -183,7 +183,6 @@ static int __devinit max17042_probe(struct i2c_client *client,
> > ret = power_supply_register(&client->dev, &chip->battery);
> > if (ret) {
> > dev_err(&client->dev, "failed: power supply register\n");
> > - i2c_set_clientdata(client, NULL);
> > kfree(chip);
> > return ret;
> > }
> > @@ -202,7 +201,6 @@ static int __devexit max17042_remove(struct i2c_client *client)
> > struct max17042_chip *chip = i2c_get_clientdata(client);
> >
> > power_supply_unregister(&chip->battery);
> > - i2c_set_clientdata(client, NULL);
> > kfree(chip);
> > return 0;
> > }
>
>
> --
> Jean Delvare
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
