Wei, I'm trying to consolidate the two Tegra I2C slave mode patches we posted to the mailing lists: Yours: http://www.spinics.net/lists/linux-i2c/msg05437.html Mine: http://www.spinics.net/lists/linux-i2c/msg05464.html I had some questions: 1) Why does your patch enable I2C_SL_CNFG_NACK. According to the Tegra documentation, this prevents the slave I2C controller from ACKing any transfers. Doesn't this prevent the slave functionality from working at all? 2) Your patch sets up the slave_addr registers based on platform data. However, I don't see any code in i2c-tegra.c to actually act as a slave device. Hence, it seems pointless to configure the slave address. Are those two things bug workarounds or something? I know that Marc said he'd like to see the slave address configuration code merged, since the AC100 uses it. However, I'm having a hard time seeing how it'll make any difference to the driver right now; it seems if/when slave mode is actually implemented, the slave_addr setup should be part of that patch. Thanks for any feedback. -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
